Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1691813003: Add --auto-open-devtools-for-tabs flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: close last DevToolsWindow Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_auto_opener.cc ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/cancelable_callback.h" 8 #include "base/cancelable_callback.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 ASSERT_TRUE( 1018 ASSERT_TRUE(
1019 content::ExecuteScriptAndExtractString( 1019 content::ExecuteScriptAndExtractString(
1020 main_web_contents()->GetRenderViewHost(), 1020 main_web_contents()->GetRenderViewHost(),
1021 "window.domAutomationController.send(" 1021 "window.domAutomationController.send("
1022 " '' + (window.uiTests && (typeof uiTests.dispatchOnTestSuite)));", 1022 " '' + (window.uiTests && (typeof uiTests.dispatchOnTestSuite)));",
1023 &result)); 1023 &result));
1024 ASSERT_EQ("function", result) << "DevTools front-end is broken."; 1024 ASSERT_EQ("function", result) << "DevTools front-end is broken.";
1025 CloseDevToolsWindow(); 1025 CloseDevToolsWindow();
1026 } 1026 }
1027 1027
1028 class DevToolsAutoOpenerTest : public DevToolsSanityTest {
1029 public:
1030 void SetUpCommandLine(base::CommandLine* command_line) override {
1031 command_line->AppendSwitch(switches::kAutoOpenDevToolsForTabs);
1032 }
1033 };
1034
1035 IN_PROC_BROWSER_TEST_F(DevToolsAutoOpenerTest, TestAutoOpenForTabs) {
1036 {
1037 scoped_refptr<content::DevToolsAgentHost> agent(
1038 content::DevToolsAgentHost::GetOrCreateFor(GetInspectedTab()));
1039 DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
1040 ASSERT_TRUE(window);
1041 DevToolsWindowTesting::CloseDevToolsWindowSync(window);
1042 }
1043 {
1044 DevToolsWindowCreationObserver observer;
1045 AddTabAtIndexToBrowser(browser(), 0, GURL("about:blank"),
1046 ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false);
1047 observer.WaitForLoad();
1048 DevToolsWindowTesting::CloseDevToolsWindowSync(observer.devtools_window());
1049 }
1050 {
1051 DevToolsWindowCreationObserver observer;
1052 Browser* new_browser = CreateBrowser(browser()->profile());
1053 AddTabAtIndexToBrowser(new_browser, 0, GURL("about:blank"),
1054 ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false);
1055 observer.WaitForLoad();
1056 DevToolsWindowTesting::CloseDevToolsWindowSync(observer.devtools_window());
1057 }
1058 }
1059
1028 class DevToolsReattachAfterCrashTest : public DevToolsSanityTest { 1060 class DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
1029 protected: 1061 protected:
1030 void RunTestWithPanel(const char* panel_name) { 1062 void RunTestWithPanel(const char* panel_name) {
1031 OpenDevToolsWindow("about:blank", false); 1063 OpenDevToolsWindow("about:blank", false);
1032 SwitchToPanel(window_, panel_name); 1064 SwitchToPanel(window_, panel_name);
1033 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)); 1065 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
1034 1066
1035 content::RenderProcessHostWatcher crash_observer( 1067 content::RenderProcessHostWatcher crash_observer(
1036 GetInspectedTab(), 1068 GetInspectedTab(),
1037 content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT); 1069 content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 1242
1211 SimulateTapAt(web_contents, gfx::Point(30, 60)); 1243 SimulateTapAt(web_contents, gfx::Point(30, 60));
1212 DispatchInPageAndWait("waitForEvent", "gesturetap"); 1244 DispatchInPageAndWait("waitForEvent", "gesturetap");
1213 1245
1214 DispatchAndWait("stopTimeline"); 1246 DispatchAndWait("stopTimeline");
1215 RunTestMethod("checkInputEventsPresent", "MouseMove", "MouseDown", 1247 RunTestMethod("checkInputEventsPresent", "MouseMove", "MouseDown",
1216 "MouseWheel", "GestureTap"); 1248 "MouseWheel", "GestureTap");
1217 1249
1218 CloseDevToolsWindow(); 1250 CloseDevToolsWindow();
1219 } 1251 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/devtools_auto_opener.cc ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698