Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1691813003: Add --auto-open-devtools-for-tabs flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: close last DevToolsWindow Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_auto_opener.cc ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 39013af3b61d4ac56e1e2cb6ad9a82ba7ee16ad5..5edac6759a2c48578cd9cbb6cbfb02ceefc37124 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -1025,6 +1025,38 @@ IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestPageWithNoJavaScript) {
CloseDevToolsWindow();
}
+class DevToolsAutoOpenerTest : public DevToolsSanityTest {
+ public:
+ void SetUpCommandLine(base::CommandLine* command_line) override {
+ command_line->AppendSwitch(switches::kAutoOpenDevToolsForTabs);
+ }
+};
+
+IN_PROC_BROWSER_TEST_F(DevToolsAutoOpenerTest, TestAutoOpenForTabs) {
+ {
+ scoped_refptr<content::DevToolsAgentHost> agent(
+ content::DevToolsAgentHost::GetOrCreateFor(GetInspectedTab()));
+ DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
+ ASSERT_TRUE(window);
+ DevToolsWindowTesting::CloseDevToolsWindowSync(window);
+ }
+ {
+ DevToolsWindowCreationObserver observer;
+ AddTabAtIndexToBrowser(browser(), 0, GURL("about:blank"),
+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false);
+ observer.WaitForLoad();
+ DevToolsWindowTesting::CloseDevToolsWindowSync(observer.devtools_window());
+ }
+ {
+ DevToolsWindowCreationObserver observer;
+ Browser* new_browser = CreateBrowser(browser()->profile());
+ AddTabAtIndexToBrowser(new_browser, 0, GURL("about:blank"),
+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false);
+ observer.WaitForLoad();
+ DevToolsWindowTesting::CloseDevToolsWindowSync(observer.devtools_window());
+ }
+}
+
class DevToolsReattachAfterCrashTest : public DevToolsSanityTest {
protected:
void RunTestWithPanel(const char* panel_name) {
« no previous file with comments | « chrome/browser/devtools/devtools_auto_opener.cc ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698