Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1691503002: Pass a GrContext pointer in GrDrawContext constructor (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@tc-cleanup-4
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M include/gpu/GrDrawContext.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
joshualitt
4 years, 10 months ago (2016-02-10 18:16:18 UTC) #3
robertphillips
lgtm
4 years, 10 months ago (2016-02-10 18:37:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691503002/20001
4 years, 10 months ago (2016-02-11 14:16:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/6315)
4 years, 10 months ago (2016-02-11 14:17:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691503002/20001
4 years, 10 months ago (2016-02-11 14:28:33 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 14:46:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1b39f439413c52eb5b172834775104a89eb229aa

Powered by Google App Engine
This is Rietveld 408576698