Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1686143003: Remove GrContext* from GrTextContext (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@tc-cleanup-5-movecontext
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : make somethings static #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -172 lines) Patch
M src/gpu/GrDrawContext.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 1 1 chunk +31 lines, -24 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 15 chunks +88 lines, -90 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 2 7 chunks +36 lines, -34 lines 0 comments Download
M src/gpu/text/GrTextContext.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/text/GrTextContext.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-10 18:49:06 UTC) #3
robertphillips
lgtm + questions https://codereview.chromium.org/1686143003/diff/1/src/gpu/text/GrAtlasTextContext.cpp File src/gpu/text/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1686143003/diff/1/src/gpu/text/GrAtlasTextContext.cpp#newcode273 src/gpu/text/GrAtlasTextContext.cpp:273: can this be static now ? ...
4 years, 10 months ago (2016-02-10 19:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1686143003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1686143003/40001
4 years, 10 months ago (2016-02-11 19:27:30 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 20:00:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/27004b7e653a38570d3fd1621ed0107e5443b31a

Powered by Google App Engine
This is Rietveld 408576698