Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1685653004: Move surface props off of GrTextContext (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@tc-cleanup-3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -102 lines) Patch
M src/gpu/GrDrawContext.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 3 chunks +7 lines, -13 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 2 chunks +12 lines, -7 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 19 chunks +45 lines, -38 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 3 chunks +9 lines, -5 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 12 chunks +31 lines, -24 lines 0 comments Download
M src/gpu/text/GrTextContext.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/text/GrTextContext.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1684733005 Patch 40001

Dependent Patchsets:

Issue 1691503002 Patch 20001

Messages

Total messages: 9 (5 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-10 17:42:10 UTC) #3
robertphillips
lgtm
4 years, 10 months ago (2016-02-10 18:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1685653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1685653004/20001
4 years, 10 months ago (2016-02-11 13:15:26 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 13:42:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2c89bc153b5228c6316b5cfa070cad3d6da169ca

Powered by Google App Engine
This is Rietveld 408576698