Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index 2ae2b7f381e4502d8d3b4dbf098dd81ec675df6e..0909b3a0badd69c28ec7d7a9d39085e8c2414b64 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -454,7 +454,7 @@ void ExtensionDevToolsClientHost::SendMessageToBackend(
DebuggerSendCommandFunction* function,
const std::string& method,
SendCommand::Params::CommandParams* command_params) {
- DictionaryValue protocol_request;
+ base::DictionaryValue protocol_request;
int request_id = ++last_request_id_;
pending_requests_[request_id] = function;
protocol_request.SetInteger("id", request_id);
@@ -517,7 +517,8 @@ void ExtensionDevToolsClientHost::DispatchOnInspectorFrontend(
scoped_ptr<Value> result(base::JSONReader::Read(message));
if (!result->IsType(Value::TYPE_DICTIONARY))
return;
- DictionaryValue* dictionary = static_cast<DictionaryValue*>(result.get());
+ base::DictionaryValue* dictionary =
+ static_cast<base::DictionaryValue*>(result.get());
int id;
if (!dictionary->GetInteger("id", &id)) {
@@ -526,7 +527,7 @@ void ExtensionDevToolsClientHost::DispatchOnInspectorFrontend(
return;
OnEvent::Params params;
- DictionaryValue* params_value;
+ base::DictionaryValue* params_value;
if (dictionary->GetDictionary("params", &params_value))
params.additional_properties.Swap(params_value);
@@ -715,7 +716,7 @@ bool DebuggerSendCommandFunction::RunImpl() {
}
void DebuggerSendCommandFunction::SendResponseBody(
- DictionaryValue* response) {
+ base::DictionaryValue* response) {
Value* error_body;
if (response->Get("error", &error_body)) {
base::JSONWriter::Write(error_body, &error_);
@@ -723,7 +724,7 @@ void DebuggerSendCommandFunction::SendResponseBody(
return;
}
- DictionaryValue* result_body;
+ base::DictionaryValue* result_body;
SendCommand::Results::Result result;
if (response->GetDictionary("result", &result_body))
result.additional_properties.Swap(result_body);

Powered by Google App Engine
This is Rietveld 408576698