Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1691493002: Revise comments on various Shell interfaces. Make some methods private on ShellConnection. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revise comments on various Shell interfaces. Make some methods private on ShellConnection. R=sky@chromium.org BUG= Committed: https://crrev.com/8ce08dbe19e9e13e6de5c628b764f72c226653b6 Cr-Commit-Position: refs/heads/master@{#374712}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -64 lines) Patch
M mojo/shell/application_manager_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/app_lifetime_helper.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 2 chunks +10 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/lib/app_lifetime_helper.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 2 chunks +19 lines, -11 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 2 chunks +23 lines, -34 lines 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-10 17:50:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691493002/20001
4 years, 10 months ago (2016-02-10 17:51:57 UTC) #3
sky
LGTM
4 years, 10 months ago (2016-02-10 18:04:24 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/48366)
4 years, 10 months ago (2016-02-10 18:14:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691493002/40001
4 years, 10 months ago (2016-02-10 18:51:34 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 20:27:16 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:46 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8ce08dbe19e9e13e6de5c628b764f72c226653b6
Cr-Commit-Position: refs/heads/master@{#374712}

Powered by Google App Engine
This is Rietveld 408576698