Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: mojo/shell/public/cpp/lib/app_lifetime_helper.cc

Issue 1691493002: Revise comments on various Shell interfaces. Make some methods private on ShellConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/connection.h ('k') | mojo/shell/public/cpp/shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/lib/app_lifetime_helper.cc
diff --git a/mojo/shell/public/cpp/lib/app_lifetime_helper.cc b/mojo/shell/public/cpp/lib/app_lifetime_helper.cc
index b2a95a79141ee53a3ffbab07ac38f8603894fe1f..cc89cade961b06967e331f5668e4d4d726f99bde 100644
--- a/mojo/shell/public/cpp/lib/app_lifetime_helper.cc
+++ b/mojo/shell/public/cpp/lib/app_lifetime_helper.cc
@@ -63,8 +63,8 @@ scoped_ptr<AppRefCount> AppRefCount::Clone() {
app_lifetime_helper_, app_task_runner_));
}
-AppLifetimeHelper::AppLifetimeHelper(ShellConnection* app)
- : app_(app), ref_count_(0) {
+AppLifetimeHelper::AppLifetimeHelper(Shell* shell)
+ : shell_(shell), ref_count_(0) {
}
AppLifetimeHelper::~AppLifetimeHelper() {
@@ -82,13 +82,13 @@ void AppLifetimeHelper::AddRef() {
void AppLifetimeHelper::Release() {
if (!--ref_count_) {
- if (app_)
- app_->Quit();
+ if (shell_)
+ shell_->Quit();
}
}
void AppLifetimeHelper::OnQuit() {
- app_ = nullptr;
+ shell_ = nullptr;
}
} // namespace mojo
« no previous file with comments | « mojo/shell/public/cpp/connection.h ('k') | mojo/shell/public/cpp/shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698