Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: mojo/shell/public/cpp/app_lifetime_helper.h

Issue 1691493002: Revise comments on various Shell interfaces. Make some methods private on ShellConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | mojo/shell/public/cpp/connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/app_lifetime_helper.h
diff --git a/mojo/shell/public/cpp/app_lifetime_helper.h b/mojo/shell/public/cpp/app_lifetime_helper.h
index 14620b3a95ca89a9d59ee09b86fb6aae3bf13bb3..3755b916cbb96ef00d1d87bbc7bdfda46615d093 100644
--- a/mojo/shell/public/cpp/app_lifetime_helper.h
+++ b/mojo/shell/public/cpp/app_lifetime_helper.h
@@ -11,6 +11,7 @@
namespace mojo {
+class Shell;
class ShellConnection;
class AppLifetimeHelper;
@@ -57,7 +58,7 @@ class AppRefCount {
// quit with a call to mojo::ShellConnection::Terminate().
class AppLifetimeHelper {
public:
- explicit AppLifetimeHelper(ShellConnection* app);
+ explicit AppLifetimeHelper(Shell* shell);
~AppLifetimeHelper();
scoped_ptr<AppRefCount> CreateAppRefCount();
@@ -70,7 +71,7 @@ class AppLifetimeHelper {
friend ShellConnection;
void OnQuit();
- ShellConnection* app_;
+ Shell* shell_;
int ref_count_;
DISALLOW_COPY_AND_ASSIGN(AppLifetimeHelper);
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | mojo/shell/public/cpp/connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698