Drop [LegacyImplementedInBaseClass] from SVGURIReference IDL interface

Drop [LegacyImplementedInBaseClass] from SVGURIReference IDL interface

Drop [LegacyImplementedInBaseClass] from SVGURIReference IDL interface by
refactoring the code. Also move the SVGURIReference code from subclasses to
SVGURIReference to avoid code duplication.

R=haraken, pdr
BUG=344224
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167255

[Inactive, 2014-02-16 23:37:44]

If I'm not mistaken, this is the last [LegacyImplementedInBaseClass] :)

I will kill this extended attribute in a follow-up patch.

[pdr., 2014-02-16 23:53:55]

LGTM

https://codereview.chromium.org/169103002/diff/1/Source/core/svg/SVGUseElement.h
File Source/core/svg/SVGUseElement.h (right):

https://codereview.chromium.org/169103002/diff/1/Source/core/svg/SVGUseElemen...
Source/core/svg/SVGUseElement.h:61: virtual bool isStructurallyExternal() const
OVERRIDE { return !hrefString().isNull() && isExternalURIReference(hrefString(),
document()); }
Is this null check needed?

[Inactive, 2014-02-17 00:30:35]

https://codereview.chromium.org/169103002/diff/1/Source/core/svg/SVGUseElement.h
File Source/core/svg/SVGUseElement.h (right):

https://codereview.chromium.org/169103002/diff/1/Source/core/svg/SVGUseElemen...
Source/core/svg/SVGUseElement.h:61: virtual bool isStructurallyExternal() const
OVERRIDE { return !hrefString().isNull() && isExternalURIReference(hrefString(),
document()); }
On 2014/02/16 23:53:56, pdr wrote:
> Is this null check needed?

I quickly checked and it seems like it is really needed.

[Inactive, 2014-02-17 00:30:57]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-17 00:31:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/169103002/1

[haraken, 2014-02-17 00:49:20]

LGTM

[Inactive, 2014-02-17 01:28:32]

The CQ bit was unchecked by ch.dumez@samsung.com

[Inactive, 2014-02-17 01:28:34]

The CQ bit was checked by ch.dumez@samsung.com

[Inactive, 2014-02-17 01:45:13]

The CQ bit was unchecked by ch.dumez@samsung.com

[Inactive, 2014-02-17 01:45:26]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-17 01:45:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/169103002/1

[commit-bot: I haz the power, 2014-02-17 02:37:47]

Change committed as 167255