Chromium Code Reviews| Index: Source/core/svg/SVGUseElement.h |
| diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h |
| index c7d73606a05df33af8e0f51ba41d7808f57e5a3a..a7a0d5e4b7de2dc2968846cdbbfe5cd1f6b41eb7 100644 |
| --- a/Source/core/svg/SVGUseElement.h |
| +++ b/Source/core/svg/SVGUseElement.h |
| @@ -54,12 +54,11 @@ public: |
| SVGAnimatedLength* height() const { return m_height.get(); } |
| virtual void buildPendingResource() OVERRIDE; |
| - SVGAnimatedString* href() { return m_href.get(); } |
| private: |
| SVGUseElement(Document&, bool wasInsertedByParser); |
| - virtual bool isStructurallyExternal() const OVERRIDE { return !m_href->currentValue()->value().isNull() && isExternalURIReference(m_href->currentValue()->value(), document()); } |
| + virtual bool isStructurallyExternal() const OVERRIDE { return !hrefString().isNull() && isExternalURIReference(hrefString(), document()); } |
|
pdr.
2014/02/16 23:53:56
Is this null check needed?
Inactive
2014/02/17 00:30:36
I quickly checked and it seems like it is really n
|
| virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners(); } |
| @@ -104,7 +103,6 @@ private: |
| RefPtr<SVGAnimatedLength> m_y; |
| RefPtr<SVGAnimatedLength> m_width; |
| RefPtr<SVGAnimatedLength> m_height; |
| - RefPtr<SVGAnimatedString> m_href; |
| BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGUseElement) |
| END_DECLARE_ANIMATED_PROPERTIES |