Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: Source/core/svg/SVGUseElement.h

Issue 169103002: Drop [LegacyImplementedInBaseClass] from SVGURIReference IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGURIReference.idl ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGUseElement.h
diff --git a/Source/core/svg/SVGUseElement.h b/Source/core/svg/SVGUseElement.h
index c7d73606a05df33af8e0f51ba41d7808f57e5a3a..a7a0d5e4b7de2dc2968846cdbbfe5cd1f6b41eb7 100644
--- a/Source/core/svg/SVGUseElement.h
+++ b/Source/core/svg/SVGUseElement.h
@@ -54,12 +54,11 @@ public:
SVGAnimatedLength* height() const { return m_height.get(); }
virtual void buildPendingResource() OVERRIDE;
- SVGAnimatedString* href() { return m_href.get(); }
private:
SVGUseElement(Document&, bool wasInsertedByParser);
- virtual bool isStructurallyExternal() const OVERRIDE { return !m_href->currentValue()->value().isNull() && isExternalURIReference(m_href->currentValue()->value(), document()); }
+ virtual bool isStructurallyExternal() const OVERRIDE { return !hrefString().isNull() && isExternalURIReference(hrefString(), document()); }
pdr. 2014/02/16 23:53:56 Is this null check needed?
Inactive 2014/02/17 00:30:36 I quickly checked and it seems like it is really n
virtual bool supportsFocus() const OVERRIDE { return hasFocusEventListeners(); }
@@ -104,7 +103,6 @@ private:
RefPtr<SVGAnimatedLength> m_y;
RefPtr<SVGAnimatedLength> m_width;
RefPtr<SVGAnimatedLength> m_height;
- RefPtr<SVGAnimatedString> m_href;
BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGUseElement)
END_DECLARE_ANIMATED_PROPERTIES
« no previous file with comments | « Source/core/svg/SVGURIReference.idl ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698