Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: Source/core/svg/SVGMPathElement.cpp

Issue 169103002: Drop [LegacyImplementedInBaseClass] from SVGURIReference IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGMPathElement.cpp
diff --git a/Source/core/svg/SVGMPathElement.cpp b/Source/core/svg/SVGMPathElement.cpp
index 343b86dd173028bc7abe6c4d534317f1752f4170..155f96b6fade3b3d583588da2eb5e1b55bbf7d8f 100644
--- a/Source/core/svg/SVGMPathElement.cpp
+++ b/Source/core/svg/SVGMPathElement.cpp
@@ -36,10 +36,9 @@ END_REGISTER_ANIMATED_PROPERTIES
inline SVGMPathElement::SVGMPathElement(Document& document)
: SVGElement(SVGNames::mpathTag, document)
- , m_href(SVGAnimatedString::create(this, XLinkNames::hrefAttr, SVGString::create()))
+ , SVGURIReference(this)
{
ScriptWrappable::init(this);
- addToPropertyMap(m_href);
registerAnimatedPropertiesForSVGMPathElement();
}
@@ -60,7 +59,7 @@ void SVGMPathElement::buildPendingResource()
return;
AtomicString id;
- Element* target = SVGURIReference::targetElementFromIRIString(m_href->currentValue()->value(), document(), &id);
+ Element* target = SVGURIReference::targetElementFromIRIString(hrefString(), document(), &id);
if (!target) {
// Do not register as pending if we are already pending this resource.
if (document().accessSVGExtensions()->isElementPendingResource(this, id))
@@ -115,8 +114,7 @@ void SVGMPathElement::parseAttribute(const QualifiedName& name, const AtomicStri
if (!isSupportedAttribute(name)) {
SVGElement::parseAttribute(name, value);
- } else if (name.matches(XLinkNames::hrefAttr)) {
- m_href->setBaseValueAsString(value, parseError);
+ } else if (SVGURIReference::parseAttribute(name, value, parseError)) {
} else {
ASSERT_NOT_REACHED();
}
@@ -143,7 +141,7 @@ void SVGMPathElement::svgAttributeChanged(const QualifiedName& attrName)
SVGPathElement* SVGMPathElement::pathElement()
{
- Element* target = targetElementFromIRIString(m_href->currentValue()->value(), document());
+ Element* target = targetElementFromIRIString(hrefString(), document());
if (target && target->hasTagName(SVGNames::pathTag))
return toSVGPathElement(target);
return 0;

Powered by Google App Engine
This is Rietveld 408576698