Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1690633002: Revert of Remove the is_loading_ field from WebContentsImpl (Closed)

Created:
4 years, 10 months ago by waffles
Modified:
4 years, 10 months ago
CC:
carlosk, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the is_loading_ field from WebContentsImpl (patchset #24 id:460001 of https://codereview.chromium.org/1545973002/ ) Reason for revert: CHECK(is_loading_) appears to fail (flakily?) on Linux ChromiumOS Tests (1). More details in the bug. Original issue's description: > Remove the is_loading_ field from WebContentsImpl > > This CL removes the is_loading_ field from WebContents, in favor of only > tracking the loading state through the FrameTree. Currently the loading state > is tracked in both, leading to more complexity in the code. > > BUG=571887, 298193 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/db73eb6cf1e59e753fb53e8c744620b00606ccd5 > Cr-Commit-Position: refs/heads/master@{#374651} TBR=rockot@chromium.org,carlosk@chromium.org,nasko@chromium.org,nick@chromium.org,clamy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=571887, 298193 Committed: https://crrev.com/1c12bf40e35ffd32c6eadbf1503155b43e31bb97 Cr-Commit-Position: refs/heads/master@{#374680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -354 lines) Patch
M chrome/browser/extensions/extension_resource_request_policy_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 4 chunks +1 line, -41 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 3 chunks +2 lines, -44 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.h View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 4 chunks +10 lines, -35 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 3 chunks +12 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 5 chunks +4 lines, -16 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 9 chunks +27 lines, -28 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 6 chunks +1 line, -21 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 4 chunks +9 lines, -16 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 13 chunks +21 lines, -40 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 4 chunks +24 lines, -16 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +1 line, -23 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/test/web_contents_observer_sanity_checker.cc View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
waffles
Created Revert of Remove the is_loading_ field from WebContentsImpl
4 years, 10 months ago (2016-02-10 17:41:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690633002/1
4 years, 10 months ago (2016-02-10 17:41:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 17:45:59 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 17:46:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c12bf40e35ffd32c6eadbf1503155b43e31bb97
Cr-Commit-Position: refs/heads/master@{#374680}

Powered by Google App Engine
This is Rietveld 408576698