Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Side by Side Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1690633002: Revert of Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 24 matching lines...) Expand all
35 virtual ~NavigationControllerDelegate() {} 35 virtual ~NavigationControllerDelegate() {}
36 36
37 // Duplicates of WebContents methods. 37 // Duplicates of WebContents methods.
38 virtual RenderViewHost* GetRenderViewHost() const = 0; 38 virtual RenderViewHost* GetRenderViewHost() const = 0;
39 virtual InterstitialPage* GetInterstitialPage() const = 0; 39 virtual InterstitialPage* GetInterstitialPage() const = 0;
40 virtual const std::string& GetContentsMimeType() const = 0; 40 virtual const std::string& GetContentsMimeType() const = 0;
41 virtual void NotifyNavigationStateChanged(InvalidateTypes changed_flags) = 0; 41 virtual void NotifyNavigationStateChanged(InvalidateTypes changed_flags) = 0;
42 virtual void Stop() = 0; 42 virtual void Stop() = 0;
43 virtual int32_t GetMaxPageID() = 0; 43 virtual int32_t GetMaxPageID() = 0;
44 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0; 44 virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;
45 virtual bool IsLoading() const = 0;
45 virtual bool IsBeingDestroyed() const = 0; 46 virtual bool IsBeingDestroyed() const = 0;
46 virtual bool CanOverscrollContent() const = 0; 47 virtual bool CanOverscrollContent() const = 0;
47 48
48 // Methods from WebContentsImpl that NavigationControllerImpl needs to 49 // Methods from WebContentsImpl that NavigationControllerImpl needs to
49 // call. 50 // call.
50 virtual FrameTree* GetFrameTree() = 0; 51 virtual FrameTree* GetFrameTree() = 0;
51 virtual void NotifyBeforeFormRepostWarningShow() = 0; 52 virtual void NotifyBeforeFormRepostWarningShow() = 0;
52 virtual void NotifyNavigationEntryCommitted( 53 virtual void NotifyNavigationEntryCommitted(
53 const LoadCommittedDetails& load_details) = 0; 54 const LoadCommittedDetails& load_details) = 0;
54 virtual void SetHistoryOffsetAndLength(int history_offset, 55 virtual void SetHistoryOffsetAndLength(int history_offset,
55 int history_length) = 0; 56 int history_length) = 0;
56 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0; 57 virtual void CopyMaxPageIDsFrom(WebContents* web_contents) = 0;
57 virtual void UpdateMaxPageID(int32_t page_id) = 0; 58 virtual void UpdateMaxPageID(int32_t page_id) = 0;
58 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance, 59 virtual void UpdateMaxPageIDForSiteInstance(SiteInstance* site_instance,
59 int32_t page_id) = 0; 60 int32_t page_id) = 0;
60 virtual void ActivateAndShowRepostFormWarningDialog() = 0; 61 virtual void ActivateAndShowRepostFormWarningDialog() = 0;
61 virtual bool HasAccessedInitialDocument() = 0; 62 virtual bool HasAccessedInitialDocument() = 0;
62 63
63 // This method is needed, since we are no longer guaranteed that the 64 // This method is needed, since we are no longer guaranteed that the
64 // embedder for NavigationController will be a WebContents object. 65 // embedder for NavigationController will be a WebContents object.
65 virtual WebContents* GetWebContents() = 0; 66 virtual WebContents* GetWebContents() = 0;
66 67
67 // Methods needed by InterstitialPageImpl. 68 // Methods needed by InterstitialPageImpl.
68 virtual bool IsHidden() = 0; 69 virtual bool IsHidden() = 0;
69 virtual void RenderFrameForInterstitialPageCreated( 70 virtual void RenderFrameForInterstitialPageCreated(
70 RenderFrameHost* render_frame_host) = 0; 71 RenderFrameHost* render_frame_host) = 0;
71 virtual void AttachInterstitialPage( 72 virtual void AttachInterstitialPage(
72 InterstitialPageImpl* interstitial_page) = 0; 73 InterstitialPageImpl* interstitial_page) = 0;
73 virtual void DidProceedOnInterstitial() = 0;
74 virtual void DetachInterstitialPage() = 0; 74 virtual void DetachInterstitialPage() = 0;
75 virtual void SetIsLoading(bool is_loading,
76 bool to_different_document,
77 LoadNotificationDetails* details) = 0;
75 }; 78 };
76 79
77 } // namespace content 80 } // namespace content
78 81
79 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_ 82 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698