content/browser/frame_host/navigation_controller_delegate.h - Issue 1690633002: Revert of Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_delegate.h

Issue 1690633002: Revert of Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_delegate.h

diff --git a/content/browser/frame_host/navigation_controller_delegate.h b/content/browser/frame_host/navigation_controller_delegate.h

index 8a20e2bcd0171c58b833bddbc3a2698fca45fae3..9922ac59817e12c4e0c88a882e1ab3a25c0bc1ba 100644

--- a/content/browser/frame_host/navigation_controller_delegate.h

+++ b/content/browser/frame_host/navigation_controller_delegate.h

@@ -42,6 +42,7 @@

virtual void Stop() = 0;

virtual int32_t GetMaxPageID() = 0;

virtual int32_t GetMaxPageIDForSiteInstance(SiteInstance* site_instance) = 0;

+ virtual bool IsLoading() const = 0;

virtual bool IsBeingDestroyed() const = 0;

virtual bool CanOverscrollContent() const = 0;

@@ -70,8 +71,10 @@

RenderFrameHost* render_frame_host) = 0;

virtual void AttachInterstitialPage(

InterstitialPageImpl* interstitial_page) = 0;

- virtual void DidProceedOnInterstitial() = 0;

virtual void DetachInterstitialPage() = 0;

+ virtual void SetIsLoading(bool is_loading,

+ bool to_different_document,

+ LoadNotificationDetails* details) = 0;

};

} // namespace content