ui/views/controls/textfield/textfield.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Make patch smaller temporarily. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/textfield/textfield.cc

diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc

index 74d18b70564e2ea7e60de96e11fb9c83c41cfb45..a1344b0dc8ba09c89ea80e5553318ffee1936aab 100644

--- a/ui/views/controls/textfield/textfield.cc

+++ b/ui/views/controls/textfield/textfield.cc

@@ -293,7 +293,10 @@ Textfield::Textfield()

set_drag_controller(this);

GetRenderText()->SetFontList(GetDefaultFontList());

SetBorder(scoped_ptr<Border>(new FocusableBorder()));

- SetFocusable(true);

+ // On Mac, only textfields and lists are focusable by default. Hence use

+ // ALWAYS instead of CONTROL focus behavior.

+ SetFocusBehavior(ALWAYS);

if (ViewsDelegate::GetInstance()) {

password_reveal_duration_ =