ui/views/controls/table/table_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/table/table_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Make patch smaller temporarily. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/table/table_view.cc

diff --git a/ui/views/controls/table/table_view.cc b/ui/views/controls/table/table_view.cc

index 3a289f3b22c571f2efd9c80a038016b68dbd04c8..a13c9d217f8dea18330399d91226b066602de192 100644

--- a/ui/views/controls/table/table_view.cc

+++ b/ui/views/controls/table/table_view.cc

@@ -145,7 +145,11 @@ TableView::TableView(ui::TableModel* model,

visible_column.column = columns[i];

visible_columns_.push_back(visible_column);

}

- SetFocusable(true);

+ // On Mac, except textfields and lists, no control should be focusable by

+ // default. In Cocoa, lists are generally represented using NSTableView. Hence

+ // use ALWAYS instead of CONTROL focus behavior for TableView.

+ SetFocusBehavior(ALWAYS);

SetModel(model);

}