ui/views/controls/tree/tree_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/tree/tree_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Make patch smaller temporarily. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/tree/tree_view.cc

diff --git a/ui/views/controls/tree/tree_view.cc b/ui/views/controls/tree/tree_view.cc

index 30428a31cadc3a535e06d642f68697863664b61d..16c7692b178d88900929fa55d08029c02fe5bcaf 100644

--- a/ui/views/controls/tree/tree_view.cc

+++ b/ui/views/controls/tree/tree_view.cc

@@ -81,7 +81,9 @@ TreeView::TreeView()

controller_(NULL),

root_shown_(true),

row_height_(font_list_.GetHeight() + kTextVerticalPadding * 2) {

- SetFocusable(true);

+ // On Mac, only textfields and lists are focusable by default. Since TreeView

+ // represents a list, use ALWAYS instead of CONTROL focus behavior.

+ SetFocusBehavior(ALWAYS);

closed_icon_ = *ui::ResourceBundle::GetSharedInstance().GetImageNamed(

(base::i18n::IsRTL() ? IDR_FOLDER_CLOSED_RTL

: IDR_FOLDER_CLOSED)).ToImageSkia();