Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index 916ebad4a9e117c7c565961293ed9e35dcf448b2..759ce610bed32f2af6574c9cfe7b92154b295baa 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -64,6 +64,7 @@
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/controls/menu/menu_scroll_view_container.h"
#include "ui/views/controls/menu/submenu_view.h"
+#include "ui/views/style/platform_style.h"
#include "ui/views/widget/widget.h"
using base::UserMetricsAction;
@@ -268,7 +269,7 @@ class InMenuButton : public LabelButton {
~InMenuButton() override {}
void Init(InMenuButtonBackground::ButtonType type) {
- SetFocusable(true);
+ views::PlatformStyle::SetControlStyleFocus(this);
set_request_focus_on_press(false);
SetHorizontalAlignment(gfx::ALIGN_CENTER);
@@ -537,7 +538,7 @@ class AppMenu::ZoomView : public AppMenuView {
IDR_FULLSCREEN_MENU_BUTTON);
fullscreen_button_->SetImage(ImageButton::STATE_NORMAL, full_screen_image);
- fullscreen_button_->SetFocusable(true);
+ views::PlatformStyle::SetControlStyleFocus(fullscreen_button_);
fullscreen_button_->set_request_focus_on_press(false);
fullscreen_button_->set_tag(fullscreen_index);
fullscreen_button_->SetImageAlignment(

Powered by Google App Engine
This is Rietveld 408576698