Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
index 09fe6bcbccc94b50ac5c5f722c2e01104bf6db72..660f249880cef826c1e4de5be836efb87e468a7b 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
@@ -19,6 +19,7 @@
#include "ui/views/controls/label.h"
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/layout/grid_layout.h"
+#include "ui/views/style/platform_style.h"
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
@@ -178,7 +179,12 @@ PermissionSelectorView::PermissionSelectorView(
permission.source),
menu_model_.get(), button_enabled);
menu_button_->SetEnabled(button_enabled);
tapted 2016/02/23 03:01:19 View::IsFocusable() has a check for |enabled_|, so
- menu_button_->SetFocusable(button_enabled);
+
+ if (button_enabled)
+ views::PlatformStyle::SetControlStyleFocus(menu_button_);
+ else
+ menu_button_->SetFocusable(false);
+
menu_button_->SetAccessibleName(
WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
layout->AddView(menu_button_);

Powered by Google App Engine
This is Rietveld 408576698