chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/download/download_shelf_view.cc ('K') | « chrome/browser/ui/views/profiles/profile_chooser_view.cc ('k') | chrome/browser/ui/views/toolbar/app_menu.cc » ('j') | chrome/browser/ui/views/website_settings/permission_selector_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

index 4d6dff5c3870114183ee6a521fd8e34c498f7bde..c9fc4932ae064f587c93bfa59cdac2ad670e2573 100644

--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

@@ -20,6 +20,7 @@

#include "ui/gfx/vector_icons.h"

#include "ui/views/controls/webview/webview.h"

#include "ui/views/layout/fill_layout.h"

+#include "ui/views/style/platform_style.h"

#include "ui/views/widget/widget.h"

#include "ui/views/widget/widget_delegate.h"

@@ -40,7 +41,7 @@ class HostView : public views::View {

back_button_(new views::ImageButton(button_listener)) {

back_button_->SetImageAlignment(views::ImageButton::ALIGN_LEFT,

views::ImageButton::ALIGN_MIDDLE);

- back_button_->SetFocusable(true);

+ views::PlatformStyle::SetControlStyleFocus(back_button_);

ShowCloseButton();

AddChildView(contents_);

SetLayoutManager(new views::FillLayout);