Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3231)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index 7cf53c30ff5457947fd74990d30f6ce57e8b1039..5d0c20b33947d0d56643b4a50c055196e1c92495 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -47,6 +47,7 @@
#include "ui/views/controls/separator.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/painter.h"
+#include "ui/views/style/platform_style.h"
#include "ui/views/view_targeter.h"
#include "ui/views/widget/widget.h"
@@ -153,7 +154,7 @@ FindBarView::FindBarView(FindBarHost* host)
}
find_previous_button_->set_id(VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);
- find_previous_button_->SetFocusable(true);
+ views::PlatformStyle::SetControlStyleFocus(find_previous_button_);
find_previous_button_->set_request_focus_on_press(false);
find_previous_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));
@@ -162,7 +163,7 @@ FindBarView::FindBarView(FindBarHost* host)
AddChildView(find_previous_button_);
find_next_button_->set_id(VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);
- find_next_button_->SetFocusable(true);
+ views::PlatformStyle::SetControlStyleFocus(find_next_button_);
find_next_button_->set_request_focus_on_press(false);
find_next_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));
@@ -171,7 +172,7 @@ FindBarView::FindBarView(FindBarHost* host)
AddChildView(find_next_button_);
close_button_->set_id(VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON);
- close_button_->SetFocusable(true);
+ views::PlatformStyle::SetControlStyleFocus(close_button_);
close_button_->set_request_focus_on_press(false);
close_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));

Powered by Google App Engine
This is Rietveld 408576698