chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc - Issue 1690543004: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

Issue 1690543004: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix FocusManagerTest.StoreFocusedView Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

diff --git a/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc b/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

index 6d8c8c65c85d580fe206030d4bbb53c0648e88db..d9fad3e6a1d442e36fb1a137d3cda9ee06013fb1 100644

--- a/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

+++ b/chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc

@@ -19,6 +19,7 @@

#include "ui/views/controls/label.h"

#include "ui/views/layout/box_layout.h"

#include "ui/views/layout/layout_constants.h"

+#include "ui/views/style/platform_style.h"

namespace {

@@ -60,7 +61,7 @@ MediaGalleryCheckboxView::MediaGalleryCheckboxView(

views::ImageButton::ALIGN_MIDDLE);

folder_viewer_button_->SetAccessibleName(l10n_util::GetStringUTF16(

IDS_MEDIA_GALLERIES_SCAN_RESULT_OPEN_FOLDER_VIEW_ACCESSIBILITY_NAME));

- folder_viewer_button_->SetFocusable(true);

+ views::PlatformStyle::SetControlStyleFocus(folder_viewer_button_);

folder_viewer_button_->SetVisible(show_folder_button);

folder_viewer_button_->SetBorder(views::Border::CreateEmptyBorder(

0, views::kRelatedControlSmallHorizontalSpacing, 0, 0));