Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1690253002: Align IntrinsicSizingInfo with computeIntrinsicDimensions (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 10 months ago
Reviewers:
fs
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, krit, f(malita), jchaffraix+rendering, blink-reviews, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align IntrinsicSizingInfo with computeIntrinsicDimensions Store aspect ratio as a ratio between two floats rather than a double, in the same way as is done in Image::computeIntrinsicDimensions(). BUG=581357 Committed: https://crrev.com/ef5cba1113c78531530a6fd18bf3716d666f1eff Cr-Commit-Position: refs/heads/master@{#375364}

Patch Set 1 #

Patch Set 2 : More rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 5 chunks +19 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
davve
Another one on the way towards unifying how intrinsic sizing works within Blink. Two tests ...
4 years, 10 months ago (2016-02-12 13:26:13 UTC) #2
fs
On 2016/02/12 at 13:26:13, davve wrote: > Another one on the way towards unifying how ...
4 years, 10 months ago (2016-02-12 14:27:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690253002/20001
4 years, 10 months ago (2016-02-13 16:48:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-13 17:55:18 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:47:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef5cba1113c78531530a6fd18bf3716d666f1eff
Cr-Commit-Position: refs/heads/master@{#375364}

Powered by Google App Engine
This is Rietveld 408576698