third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp - Issue 1690253002: Align IntrinsicSizingInfo with computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 1690253002: Align IntrinsicSizingInfo with computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More rebaselines Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutReplaced.cpp ('k') | third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

index 6a16ef6e0c526312cb58eb02bede00019b3fea8b..0fc5ba0b7af063cf1f755076ae7027130d6d1c67 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp

@@ -84,12 +84,12 @@ void LayoutSVGRoot::computeIntrinsicSizingInfo(IntrinsicSizingInfo& intrinsicSiz

intrinsicSizingInfo.hasHeight = svg->hasIntrinsicHeight();

if (!intrinsicSizingInfo.size.isEmpty()) {

- intrinsicSizingInfo.aspectRatio = intrinsicSizingInfo.size.width() / static_cast<double>(intrinsicSizingInfo.size.height());

+ intrinsicSizingInfo.aspectRatio = intrinsicSizingInfo.size;

} else {

FloatSize viewBoxSize = svg->viewBox()->currentValue()->value().size();

if (!viewBoxSize.isEmpty()) {

// The viewBox can only yield an intrinsic ratio, not an intrinsic size.

- intrinsicSizingInfo.aspectRatio = viewBoxSize.width() / static_cast<double>(viewBoxSize.height());

+ intrinsicSizingInfo.aspectRatio = viewBoxSize;

}