third_party/WebKit/Source/core/layout/LayoutImage.cpp - Issue 1690253002: Align IntrinsicSizingInfo with computeIntrinsicDimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutImage.cpp

Issue 1690253002: Align IntrinsicSizingInfo with computeIntrinsicDimensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More rebaselines Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutImage.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutImage.cpp b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

index 66d430fc5f2c01cb9035563db75e05ecf8030dc7..d5c340de55a4910712edc687c6f42d7c54ba5126 100644

--- a/third_party/WebKit/Source/core/layout/LayoutImage.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutImage.cpp

@@ -300,7 +300,7 @@ void LayoutImage::computeIntrinsicSizingInfo(IntrinsicSizingInfo& intrinsicSizin

// Don't compute an intrinsic ratio to preserve historical WebKit behavior if we're painting alt text and/or a broken image.

// Video is excluded from this behavior because video elements have a default aspect ratio that a failed poster image load should not override.

if (m_imageResource && m_imageResource->errorOccurred() && !isVideo()) {

- intrinsicSizingInfo.aspectRatio = 1;

+ intrinsicSizingInfo.aspectRatio = FloatSize(1, 1);

return;

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »