[Offline pages] Updating page info to explain offline pages properly

[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline URL.

Verbose status now responds to clicks.

BUG=585209
Committed: https://crrev.com/975536905a2bf933703192f81189f92be16588b1
Cr-Commit-Position: refs/heads/master@{#377791}

[fgorski, 2016-02-11 18:46:30]

Description was changed from

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

BUG=585209
==========

to

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

BUG=585209
==========

[fgorski, 2016-02-11 18:46:30]

fgorski@chromium.org changed reviewers:
+ jianli@chromium.org, tedchoc@chromium.org

[fgorski, 2016-02-11 18:48:29]

PTAL.

This is patch 2 for the omnibox treatment and deals with turning verbose status
into a button as well as handling the offline content on the page info dialog.

[fgorski, 2016-02-11 18:50:07]

Description was changed from

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

BUG=585209
==========

to

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

Verbose status now responds to clicks.

BUG=585209
==========

[jianli, 2016-02-11 20:27:01]

lgtm

[Ted C, 2016-02-11 21:38:27]

lgtm.  By setting an onClickListener, I'm pretty sure the view is marked as
clickable, so I still think you can drop the attribute from the xml config in
the other patch.

https://codereview.chromium.org/1689973002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1689973002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1759:
private boolean isLocationIcon(View v) {
we should probably update this to shouldShowPageInfoForView since it is now more
than just the icons.

[fgorski, 2016-02-26 01:55:58]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-02-26 01:55:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, jianli@chromium.org
Link to the patchset: https://codereview.chromium.org/1689973002/#ps80001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-02-26 01:57:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1689973002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1689973002/80001

[commit-bot: I haz the power, 2016-02-26 03:09:10]

Description was changed from

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

Verbose status now responds to clicks.

BUG=585209
==========

to

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

Verbose status now responds to clicks.

BUG=585209
==========

[commit-bot: I haz the power, 2016-02-26 03:09:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-26 03:10:33]

Description was changed from

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

Verbose status now responds to clicks.

BUG=585209
==========

to

==========
[Offline pages] Updating page info to explain offline pages properly

Updates to the page info include:
* Getting the online URL of the offline page.
* Displaying the creation date of the offline page.
* Passing in the whole tab to construct the information page.

Also, this patch update offline page bridge to allow getting the page by offline
URL.

Verbose status now responds to clicks.

BUG=585209

Committed: https://crrev.com/975536905a2bf933703192f81189f92be16588b1
Cr-Commit-Position: refs/heads/master@{#377791}
==========

[commit-bot: I haz the power, 2016-02-26 03:10:33]

Patchset 5 (id:??) landed as
https://crrev.com/975536905a2bf933703192f81189f92be16588b1
Cr-Commit-Position: refs/heads/master@{#377791}

[fgorski, 2016-02-26 16:46:38]

The comment was addressed.

https://codereview.chromium.org/1689973002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1689973002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1759:
private boolean isLocationIcon(View v) {
On 2016/02/11 21:38:27, Ted C wrote:
> we should probably update this to shouldShowPageInfoForView since it is now
more
> than just the icons.

Done.