chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1689973002: [Offline pages] Updating page info to explain offline pages properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1689973002: [Offline pages] Updating page info to explain offline pages properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@omnibox-patch-1

Patch Set: Addressing feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index fb7f9206cd5a0e6a1d7f6b9c28e0e91796d624c0..bf79b0e5fca4f8623307e5895bd3158c2f59e130 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1368,7 +1368,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

RecordUserAction.record("MobileToolbarReload");

}

} else if (id == R.id.info_menu_id) {

- WebsiteSettingsPopup.show(this, currentTab.getProfile(), currentTab.getWebContents());

+ WebsiteSettingsPopup.show(this, currentTab);

} else if (id == R.id.open_history_menu_id) {

currentTab.loadUrl(

new LoadUrlParams(UrlConstants.HISTORY_URL, PageTransition.AUTO_TOPLEVEL));

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | no next file with comments »