Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1689913003: [chrome.displaySource] Simplify session error types (Closed)

Created:
4 years, 10 months ago by Mikhail
Modified:
4 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@display_source_session_notification
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Simplify session error types This patch reduces amount of possible session error types and makes them more generic (less WiFi Display oriented). BUG=242107 Committed: https://crrev.com/dad8e717e7cad2a61661b48a37e799b008d4800a Cr-Commit-Position: refs/heads/master@{#375437}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed the nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M extensions/common/api/display_source.idl View 1 1 chunk +7 lines, -16 lines 0 comments Download
M extensions/common/mojo/wifi_display_session_service.mojom View 2 chunks +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Mikhail
PTAL
4 years, 10 months ago (2016-02-11 21:17:56 UTC) #3
Mikhail
@shalamov, regarding https://codereview.chromium.org/1674583002#msg11 I've tried that out, but it seems that duplicating the enums in ...
4 years, 10 months ago (2016-02-11 21:22:17 UTC) #4
shalamov
On 2016/02/11 21:22:17, Mikhail wrote: > @shalamov, regarding https://codereview.chromium.org/1674583002#msg11 I've tried > that out, but ...
4 years, 10 months ago (2016-02-12 12:36:52 UTC) #5
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/1689913003/diff/1/extensions/common/api/display_source.idl File extensions/common/api/display_source.idl (right): https://codereview.chromium.org/1689913003/diff/1/extensions/common/api/display_source.idl#newcode13 extensions/common/api/display_source.idl:13: // The connection with sink cannot be established ...
4 years, 10 months ago (2016-02-13 00:36:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689913003/20001
4 years, 10 months ago (2016-02-15 09:08:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 10:25:34 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:49:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dad8e717e7cad2a61661b48a37e799b008d4800a
Cr-Commit-Position: refs/heads/master@{#375437}

Powered by Google App Engine
This is Rietveld 408576698