Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: extensions/common/api/display_source.idl

Issue 1689913003: [chrome.displaySource] Simplify session error types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@display_source_session_notification
Patch Set: Fixed the nit. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/display_source.idl
diff --git a/extensions/common/api/display_source.idl b/extensions/common/api/display_source.idl
index 83cfa0dec50a4d0ade43f36195101a7c48689e5f..00434a6ad89ea685db5a7ceda6c8feb930a26f5f 100644
--- a/extensions/common/api/display_source.idl
+++ b/extensions/common/api/display_source.idl
@@ -6,31 +6,22 @@
// session using WebMediaStreamTrack as sources.
namespace displaySource {
enum ErrorType {
- // Cannot create media pipeline from the given media stream which could be
- // appropriate for a Display session (e.g., necessary codecs are missing
- // on the platform).
- create_media_pipeline_error,
-
// A new Display session cannot be started before the existing one is
// terminated.
- exceeded_session_limit_error,
+ session_limit_error,
- // Could not establish connection to the sink.
- establish_connection_error,
+ // The connection with sink cannot be established or has dropped
+ // unexpectedly.
+ connection_error,
// The capabilities of this Display Source and the connected
// sink do not fit (e.g. the sink cannot play the media content of
// the formats given by the source).
capabilities_negotiation_error,
- // There was an error while packetizing and sending the media content.
- media_send_error,
-
- // The TCP connection with sink has dropped unexpectedly.
- connection_error,
-
- // An unexpected message has arrived from the sink.
- unexpected_message_error,
+ // There was an error in media pipeline: while encoding, packetizing or
+ // sending the media content.
+ media_pipeline_error,
// The sink became unresponsive.
timeout_error,

Powered by Google App Engine
This is Rietveld 408576698