Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc

Issue 1689913003: [chrome.displaySource] Simplify session error types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@display_source_session_notification
Patch Set: Fixed the nit. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/api/display_source.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc
diff --git a/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc b/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc
index 015eca3a1c6e6140c9cb7e70d727d0f535aec597..08957fe344e16b09322549761f4bc22abe9cd529 100644
--- a/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc
+++ b/extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc
@@ -62,7 +62,7 @@ void WiFiDisplaySessionServiceImpl::Connect(int32_t sink_id,
DCHECK(client_);
// We support only one Wi-Fi Display session at a time.
if (delegate_->connection()) {
- client_->OnError(ERROR_TYPE_EXCEEDED_SESSION_LIMIT_ERROR,
+ client_->OnError(ERROR_TYPE_SESSION_LIMIT_ERROR,
kErrorCannotHaveMultipleSessions);
return;
}
@@ -72,8 +72,7 @@ void WiFiDisplaySessionServiceImpl::Connect(int32_t sink_id,
sinks.begin(), sinks.end(),
[sink_id](DisplaySourceSinkInfoPtr ptr) { return ptr->id == sink_id; });
if (found == sinks.end() || (*found)->state != SINK_STATE_DISCONNECTED) {
- client_->OnError(ERROR_TYPE_ESTABLISH_CONNECTION_ERROR,
- kErrorSinkNotAvailable);
+ client_->OnError(ERROR_TYPE_CONNECTION_ERROR, kErrorSinkNotAvailable);
return;
}
AuthenticationInfo auth_info;
@@ -182,7 +181,7 @@ void WiFiDisplaySessionServiceImpl::OnConnectFailed(
if (sink_id != sink_id_)
return;
DCHECK(client_);
- client_->OnError(ERROR_TYPE_ESTABLISH_CONNECTION_ERROR, message);
+ client_->OnError(ERROR_TYPE_CONNECTION_ERROR, message);
}
void WiFiDisplaySessionServiceImpl::OnDisconnectFailed(
« no previous file with comments | « no previous file | extensions/common/api/display_source.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698