Do not rely on a texture's internalformat matching format

Do not rely on a texture's internalformat matching format

After recently implemented support for rendering to 32-bit floating point
textures on ES3, texture's internal format and format do not necessarily
always match. Fix the command decoder code that relied on them matching.

BUG=329605
TEST=gpu_unittests, WebGL conformance tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252268

[oetuaho-nv, 2014-02-17 13:20:22]

This fixes bugs introduced in https://codereview.chromium.org/139013008/

Tested by https://github.com/KhronosGroup/WebGL/pull/477

No matter how careful you are, there always seems to be something.

[piman, 2014-02-18 20:40:10]

Could you add a unit test for the path that regressed?

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:8299: target, level,
internal_format, internal_format, GL_UNSIGNED_BYTE,
This is probably wrong for RGBA32F internal formats.

[oetuaho-nv, 2014-02-19 09:51:17]

Added the requested unit tests.

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:8299: target, level,
internal_format, internal_format, GL_UNSIGNED_BYTE,
On 2014/02/18 20:40:10, piman wrote:
> This is probably wrong for RGBA32F internal formats.

CopyTexImage2D is not specified for float textures. We might revisit this, but
not for this patch I think.

[piman, 2014-02-19 20:26:19]

lgtm

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/168983005/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:8299: target, level,
internal_format, internal_format, GL_UNSIGNED_BYTE,
On 2014/02/19 09:51:17, oetuaho-nv wrote:
> On 2014/02/18 20:40:10, piman wrote:
> > This is probably wrong for RGBA32F internal formats.
> 
> CopyTexImage2D is not specified for float textures. We might revisit this, but
> not for this patch I think.

Oh, it will fail ValidateFormatAndTypeCombination anyway, so I suppose that's
fine.

[oetuaho-nv, 2014-02-20 09:55:52]

The CQ bit was checked by oetuaho@nvidia.com

[commit-bot: I haz the power, 2014-02-20 12:44:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/168983005/150001

[commit-bot: I haz the power, 2014-02-20 15:05:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 15:05:19]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[oetuaho-nv, 2014-02-20 15:11:36]

The CQ bit was checked by oetuaho@nvidia.com

[commit-bot: I haz the power, 2014-02-20 15:12:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/168983005/150001

[commit-bot: I haz the power, 2014-02-20 16:56:27]

Change committed as 252268