third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp - Issue 1689723004: CSS Typed OM: Implement TransformValue::asMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp

Issue 1689723004: CSS Typed OM: Implement TransformValue::asMatrix (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computeLengthValue

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.h ('k') | third_party/WebKit/Source/core/css/cssom/TransformValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp b/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp

index 69a95d99548bca899d09bf9121718e1e5e93f46b..4c76200f3b86e5d1e7dad04b755e342309bf033b 100644

--- a/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp

@@ -98,4 +98,15 @@ MatrixTransformComponent* MatrixTransformComponent::translate3d(double x, double

return new MatrixTransformComponent(matrix.release(), Translation3DType);

}

+// TODO: implement multiply with case statement with TransformComponent::type()

+MatrixTransformComponent* MatrixTransformComponent::multiplySelf(const MatrixTransformComponent* other)

+ if (!other->is2DComponent())

+ m_is2D = false;

+ *m_matrix *= other->matrix();

+ return this;

} // namespace blink