Source/web/WebIDBKey.cpp - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebIDBKey.cpp

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebIDBKey.cpp

diff --git a/Source/web/WebIDBKey.cpp b/Source/web/WebIDBKey.cpp

index c61b0d60d9ef7f32d12f1ad6d2a53d79bc891fc8..cfa0b0b210d93ad0a6e0443ddcfdbcf55bdcb701 100644

--- a/Source/web/WebIDBKey.cpp

+++ b/Source/web/WebIDBKey.cpp

@@ -187,7 +187,8 @@ void WebIDBKey::assignInvalid()

void WebIDBKey::assignNull()

{

- m_private = 0;

+ // FIXME: replace reset() with nullptr assignment (cf. https://codereview.chromium.org/170603003/ )

+ m_private.reset();

}

void WebIDBKey::reset()

« no previous file with comments | « Source/web/WebDOMMediaStreamTrack.cpp ('k') | Source/web/WebIDBKeyRange.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')