Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: Source/web/WebIDBKey.cpp

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 m_private = IDBKey::createNumber(number); 180 m_private = IDBKey::createNumber(number);
181 } 181 }
182 182
183 void WebIDBKey::assignInvalid() 183 void WebIDBKey::assignInvalid()
184 { 184 {
185 m_private = IDBKey::createInvalid(); 185 m_private = IDBKey::createInvalid();
186 } 186 }
187 187
188 void WebIDBKey::assignNull() 188 void WebIDBKey::assignNull()
189 { 189 {
190 m_private = 0; 190 // FIXME: replace reset() with nullptr assignment (cf. https://codereview.ch romium.org/170603003/ )
191 m_private.reset();
191 } 192 }
192 193
193 void WebIDBKey::reset() 194 void WebIDBKey::reset()
194 { 195 {
195 m_private.reset(); 196 m_private.reset();
196 } 197 }
197 198
198 WebIDBKeyType WebIDBKey::keyType() const 199 WebIDBKeyType WebIDBKey::keyType() const
199 { 200 {
200 if (!m_private.get()) 201 if (!m_private.get())
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 m_private = value; 247 m_private = value;
247 return *this; 248 return *this;
248 } 249 }
249 250
250 WebIDBKey::operator PassRefPtr<IDBKey>() const 251 WebIDBKey::operator PassRefPtr<IDBKey>() const
251 { 252 {
252 return m_private.get(); 253 return m_private.get();
253 } 254 }
254 255
255 } // namespace blink 256 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698