Source/web/WebIDBKeyRange.cpp - Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebIDBKeyRange.cpp

Issue 168963003: Make WebPrivatePtr capable of wrapping garbage collected objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Temporarily drop back to using .reset() instead of nullptr. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebIDBKeyRange.cpp

diff --git a/Source/web/WebIDBKeyRange.cpp b/Source/web/WebIDBKeyRange.cpp

index 7ebf607407be8e6ef0552f93608132b6e6f4e30e..226de4acf91f59ca51cd220e205978980879e8a3 100644

--- a/Source/web/WebIDBKeyRange.cpp

+++ b/Source/web/WebIDBKeyRange.cpp

@@ -41,8 +41,9 @@ void WebIDBKeyRange::assign(const WebIDBKeyRange& other)

void WebIDBKeyRange::assign(const WebIDBKey& lower, const WebIDBKey& upper, bool lowerOpen, bool upperOpen)

{

+ // FIXME: replace reset() with nullptr assignment (cf. https://codereview.chromium.org/170603003/ )

if (!lower.isValid() && !upper.isValid())

- m_private = 0;

+ m_private.reset();

else

m_private = IDBKeyRange::create(lower, upper, lowerOpen ? IDBKeyRange::LowerBoundOpen : IDBKeyRange::LowerBoundClosed, upperOpen ? IDBKeyRange::UpperBoundOpen : IDBKeyRange::UpperBoundClosed);

}

« no previous file with comments | « Source/web/WebIDBKey.cpp ('k') | Source/web/WebSpeechGrammar.cpp » ('j') | public/platform/WebPrivatePtr.h » ('J')