content/shell/common/shell_messages.h - Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/common/shell_messages.h

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/common/shell_messages.h

diff --git a/content/shell/common/shell_messages.h b/content/shell/common/shell_messages.h

index 684447408ffaeddec1740a40b1b75ae3c0a149ec..acbbfb019d2c9c4adee1bf88332a0a6700247b96 100644

--- a/content/shell/common/shell_messages.h

+++ b/content/shell/common/shell_messages.h

@@ -28,15 +28,13 @@ IPC_STRUCT_TRAITS_MEMBER(expected_pixel_hash)

IPC_STRUCT_TRAITS_MEMBER(initial_size)

IPC_STRUCT_TRAITS_END()

-IPC_ENUM_TRAITS_MIN_MAX_VALUE(

- test_runner::LayoutDumpMode,

- test_runner::LayoutDumpMode::DUMP_AS_TEXT,

- test_runner::LayoutDumpMode::DUMP_SCROLL_POSITIONS)

IPC_STRUCT_TRAITS_BEGIN(test_runner::LayoutDumpFlags)

- IPC_STRUCT_TRAITS_MEMBER(main_dump_mode)

- IPC_STRUCT_TRAITS_MEMBER(dump_as_printed)

- IPC_STRUCT_TRAITS_MEMBER(dump_child_frames)

+ IPC_STRUCT_TRAITS_MEMBER(dump_as_text)

+ IPC_STRUCT_TRAITS_MEMBER(dump_child_frames_as_text)

+ IPC_STRUCT_TRAITS_MEMBER(dump_as_markup)

+ IPC_STRUCT_TRAITS_MEMBER(dump_child_frames_as_markup)

+ IPC_STRUCT_TRAITS_MEMBER(dump_child_frame_scroll_positions)

+ IPC_STRUCT_TRAITS_MEMBER(is_printing)

IPC_STRUCT_TRAITS_MEMBER(dump_line_box_trees)

IPC_STRUCT_TRAITS_MEMBER(debug_render_tree)

IPC_STRUCT_TRAITS_END()