Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: content/shell/common/shell_messages.h

Issue 1689283003: Remove duplication between TestRunner's fields and LayoutDumpFlags struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Despite LayoutDumpFlags constructor, we still need to set the flags in TestRunner::Reset. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included file, no traditional include guard. 5 // Multiply-included file, no traditional include guard.
6 #include <string> 6 #include <string>
7 #include <vector> 7 #include <vector>
8 8
9 #include "components/test_runner/layout_dump_flags.h" 9 #include "components/test_runner/layout_dump_flags.h"
10 #include "content/public/common/common_param_traits.h" 10 #include "content/public/common/common_param_traits.h"
(...skipping 10 matching lines...) Expand all
21 IPC_STRUCT_TRAITS_BEGIN(content::ShellTestConfiguration) 21 IPC_STRUCT_TRAITS_BEGIN(content::ShellTestConfiguration)
22 IPC_STRUCT_TRAITS_MEMBER(current_working_directory) 22 IPC_STRUCT_TRAITS_MEMBER(current_working_directory)
23 IPC_STRUCT_TRAITS_MEMBER(temp_path) 23 IPC_STRUCT_TRAITS_MEMBER(temp_path)
24 IPC_STRUCT_TRAITS_MEMBER(test_url) 24 IPC_STRUCT_TRAITS_MEMBER(test_url)
25 IPC_STRUCT_TRAITS_MEMBER(enable_pixel_dumping) 25 IPC_STRUCT_TRAITS_MEMBER(enable_pixel_dumping)
26 IPC_STRUCT_TRAITS_MEMBER(allow_external_pages) 26 IPC_STRUCT_TRAITS_MEMBER(allow_external_pages)
27 IPC_STRUCT_TRAITS_MEMBER(expected_pixel_hash) 27 IPC_STRUCT_TRAITS_MEMBER(expected_pixel_hash)
28 IPC_STRUCT_TRAITS_MEMBER(initial_size) 28 IPC_STRUCT_TRAITS_MEMBER(initial_size)
29 IPC_STRUCT_TRAITS_END() 29 IPC_STRUCT_TRAITS_END()
30 30
31 IPC_ENUM_TRAITS_MIN_MAX_VALUE(
32 test_runner::LayoutDumpMode,
33 test_runner::LayoutDumpMode::DUMP_AS_TEXT,
34 test_runner::LayoutDumpMode::DUMP_SCROLL_POSITIONS)
35
36 IPC_STRUCT_TRAITS_BEGIN(test_runner::LayoutDumpFlags) 31 IPC_STRUCT_TRAITS_BEGIN(test_runner::LayoutDumpFlags)
37 IPC_STRUCT_TRAITS_MEMBER(main_dump_mode) 32 IPC_STRUCT_TRAITS_MEMBER(dump_as_text)
38 IPC_STRUCT_TRAITS_MEMBER(dump_as_printed) 33 IPC_STRUCT_TRAITS_MEMBER(dump_child_frames_as_text)
39 IPC_STRUCT_TRAITS_MEMBER(dump_child_frames) 34 IPC_STRUCT_TRAITS_MEMBER(dump_as_markup)
35 IPC_STRUCT_TRAITS_MEMBER(dump_child_frames_as_markup)
36 IPC_STRUCT_TRAITS_MEMBER(dump_child_frame_scroll_positions)
37 IPC_STRUCT_TRAITS_MEMBER(is_printing)
40 IPC_STRUCT_TRAITS_MEMBER(dump_line_box_trees) 38 IPC_STRUCT_TRAITS_MEMBER(dump_line_box_trees)
41 IPC_STRUCT_TRAITS_MEMBER(debug_render_tree) 39 IPC_STRUCT_TRAITS_MEMBER(debug_render_tree)
42 IPC_STRUCT_TRAITS_END() 40 IPC_STRUCT_TRAITS_END()
43 41
44 // Tells the renderer to reset all test runners. 42 // Tells the renderer to reset all test runners.
45 IPC_MESSAGE_ROUTED0(ShellViewMsg_Reset) 43 IPC_MESSAGE_ROUTED0(ShellViewMsg_Reset)
46 44
47 // Sets the path to the WebKit checkout. 45 // Sets the path to the WebKit checkout.
48 IPC_MESSAGE_CONTROL1(ShellViewMsg_SetWebKitSourceDir, 46 IPC_MESSAGE_CONTROL1(ShellViewMsg_SetWebKitSourceDir,
49 base::FilePath /* webkit source dir */) 47 base::FilePath /* webkit source dir */)
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 content::LeakDetectionResult /* result */) 132 content::LeakDetectionResult /* result */)
135 133
136 IPC_MESSAGE_ROUTED1(ShellViewHostMsg_SetBluetoothManualChooser, 134 IPC_MESSAGE_ROUTED1(ShellViewHostMsg_SetBluetoothManualChooser,
137 bool /* enable */) 135 bool /* enable */)
138 IPC_MESSAGE_ROUTED0(ShellViewHostMsg_GetBluetoothManualChooserEvents) 136 IPC_MESSAGE_ROUTED0(ShellViewHostMsg_GetBluetoothManualChooserEvents)
139 IPC_MESSAGE_ROUTED1(ShellViewMsg_ReplyBluetoothManualChooserEvents, 137 IPC_MESSAGE_ROUTED1(ShellViewMsg_ReplyBluetoothManualChooserEvents,
140 std::vector<std::string> /* events */) 138 std::vector<std::string> /* events */)
141 IPC_MESSAGE_ROUTED2(ShellViewHostMsg_SendBluetoothManualChooserEvent, 139 IPC_MESSAGE_ROUTED2(ShellViewHostMsg_SendBluetoothManualChooserEvent,
142 std::string /* event */, 140 std::string /* event */,
143 std::string /* argument */) 141 std::string /* argument */)
OLDNEW
« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/renderer/layout_test/blink_test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698