Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Blackboxing in LiveLocations is supported in Linkifier R=dgozman@chromium.org BUG=583193 Committed: https://crrev.com/d748668121a6f525011b6dd0b2532c3ee47a9573 Cr-Commit-Position: refs/heads/master@{#376278}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Messages

Total messages: 17 (5 generated)
kozy
ptal
4 years, 10 months ago (2016-02-16 19:30:47 UTC) #1
dgozman
https://codereview.chromium.org/1688283002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/1688283002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode323 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:323: location.update(); Let's check that DebuggerWorkspaceBinding already does this. https://codereview.chromium.org/1688283002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js ...
4 years, 10 months ago (2016-02-17 22:46:22 UTC) #2
kozy
All done. Please take a look. https://codereview.chromium.org/1688283002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/1688283002/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode323 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:323: location.update(); On 2016/02/17 ...
4 years, 10 months ago (2016-02-18 01:52:25 UTC) #3
dgozman
https://codereview.chromium.org/1688283002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/1688283002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode315 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:315: } else if (!this._scriptIdToPositions.has(script.scriptId)) nit: {} for both branches ...
4 years, 10 months ago (2016-02-18 02:17:54 UTC) #4
kozy
All done. https://codereview.chromium.org/1688283002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/1688283002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode315 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:315: } else if (!this._scriptIdToPositions.has(script.scriptId)) On 2016/02/18 02:17:53, ...
4 years, 10 months ago (2016-02-18 02:36:26 UTC) #7
dgozman
https://codereview.chromium.org/1688283002/diff/80001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js (right): https://codereview.chromium.org/1688283002/diff/80001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js#newcode534 third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:534: return uiLocation; nit: please revert https://codereview.chromium.org/1688283002/diff/80001/third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js File third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js (right): ...
4 years, 10 months ago (2016-02-18 02:42:50 UTC) #8
kozy
All done! https://codereview.chromium.org/1688283002/diff/80001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js (right): https://codereview.chromium.org/1688283002/diff/80001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js#newcode534 third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:534: return uiLocation; On 2016/02/18 02:42:50, dgozman wrote: ...
4 years, 10 months ago (2016-02-18 02:55:44 UTC) #10
kozy
All done. please take a look.
4 years, 10 months ago (2016-02-18 19:16:28 UTC) #11
dgozman
lgtm
4 years, 10 months ago (2016-02-18 20:09:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688283002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688283002/140001
4 years, 10 months ago (2016-02-18 20:15:39 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:140001)
4 years, 10 months ago (2016-02-18 21:49:34 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 21:50:58 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/d748668121a6f525011b6dd0b2532c3ee47a9573
Cr-Commit-Position: refs/heads/master@{#376278}

Powered by Google App Engine
This is Rietveld 408576698