Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1699183003: [DevTools] Don't load sourcemap for blackboxed scripts (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Don't load sourcemap for blackboxed scripts BUG=583193 R=dgozman@chromium.org Committed: https://crrev.com/b8dd88a0dea01d96b1cde5d910c0ac85af69c67e Cr-Commit-Position: refs/heads/master@{#376789}

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 1 2 3 4 4 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (3 generated)
kozy
ptal
4 years, 10 months ago (2016-02-16 19:30:28 UTC) #1
kozy
Rebased, ready for review.
4 years, 10 months ago (2016-02-18 02:01:47 UTC) #2
paulirish
In this situation, we need to log a message saying what we did. Otherwise, this ...
4 years, 10 months ago (2016-02-18 02:12:31 UTC) #3
dgozman
> In this situation, we need to log a message saying what we did. I'd ...
4 years, 10 months ago (2016-02-18 02:37:41 UTC) #4
kozy
All done and message added to blackbox infobar. https://codereview.chromium.org/1699183003/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js (right): https://codereview.chromium.org/1699183003/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js#newcode171 third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:171: loadSourceMap: ...
4 years, 10 months ago (2016-02-19 02:24:51 UTC) #5
dgozman
lgtm modulo UI string. Please consult with Paul. https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js (right): https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js#newcode483 third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js:483: isBlackboxed: ...
4 years, 10 months ago (2016-02-20 02:50:33 UTC) #6
kozy
All done. Still waiting for cool message for users in blackbox infobar from Paul :) ...
4 years, 10 months ago (2016-02-22 05:12:14 UTC) #7
dgozman
https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js (right): https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js#newcode198 third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js:198: var location = this._debuggerModel.createRawLocation(script, 0, 0); On 2016/02/22 05:12:14, ...
4 years, 10 months ago (2016-02-22 17:34:56 UTC) #8
paulirish
https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js File third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js (right): https://codereview.chromium.org/1699183003/diff/40001/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js#newcode168 third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:168: infobar.createDetailsRowMessage(WebInspector.UIString("SourceMap will be ignored for this file.")); "Source map ...
4 years, 10 months ago (2016-02-22 18:47:41 UTC) #9
kozy
Thank you! All done.
4 years, 10 months ago (2016-02-22 18:55:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699183003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699183003/100001
4 years, 10 months ago (2016-02-22 18:56:10 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-22 20:12:38 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 20:14:34 UTC) #16
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/b8dd88a0dea01d96b1cde5d910c0ac85af69c67e
Cr-Commit-Position: refs/heads/master@{#376789}

Powered by Google App Engine
This is Rietveld 408576698