third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1688283002: [DevTools] Blackboxing in LiveLocations is supported in Linkifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-map-support-v3

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/LiveLocation.js ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index 0f66b56b2209243d9d9862a35c5dd1b6df198982..7d54c7041d51c09350d820fed38871ada4367289 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -173,12 +173,15 @@ WebInspector.PresentationConsoleMessage = function(message, rawLocation)

WebInspector.PresentationConsoleMessage.prototype = {

/**

- * @param {!WebInspector.UILocation} uiLocation

+ * @param {!WebInspector.LiveLocation} liveLocation

- _updateLocation: function(uiLocation)

+ _updateLocation: function(liveLocation)

{

if (this._uiMessage)

this._uiMessage.remove();

+ var uiLocation = liveLocation.uiLocation();

+ if (!uiLocation)

+ return;

this._uiMessage = uiLocation.uiSourceCode.addLineMessage(this._level, this._text, uiLocation.lineNumber, uiLocation.columnNumber);