Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1688233004: Validate that (actual) resynthesized elements have the same runtimeType as originals. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Validate that (actual) resynthesized elements have the same runtimeType as originals. Also some tweaks for the found inconsistencies. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/878f3b9b1ba9eaeacecde020f1d46cb75cb447fa

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use actual double.X values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -34 lines) Patch
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 3 chunks +15 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 1 5 chunks +18 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 3 chunks +4 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 3 chunks +16 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 10 months ago (2016-02-12 18:44:26 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart File pkg/analyzer/lib/src/generated/testing/test_type_provider.dart (right): https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart#newcode635 pkg/analyzer/lib/src/generated/testing/test_type_provider.dart:635: initializer: AstFactory.doubleLiteral(0.0)), Let's set these to the appropriate ...
4 years, 10 months ago (2016-02-12 18:52:50 UTC) #2
scheglov
https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart File pkg/analyzer/lib/src/generated/testing/test_type_provider.dart (right): https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart#newcode635 pkg/analyzer/lib/src/generated/testing/test_type_provider.dart:635: initializer: AstFactory.doubleLiteral(0.0)), On 2016/02/12 18:52:50, Paul Berry wrote: > ...
4 years, 10 months ago (2016-02-12 19:31:42 UTC) #3
scheglov
Committed patchset #2 (id:20001) manually as 878f3b9b1ba9eaeacecde020f1d46cb75cb447fa (presubmit successful).
4 years, 10 months ago (2016-02-12 19:32:10 UTC) #5
Paul Berry
4 years, 10 months ago (2016-02-12 19:33:51 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/testing/test_type_provider.dart (right):

https://codereview.chromium.org/1688233004/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/testing/test_type_provider.dart:635: initializer:
AstFactory.doubleLiteral(0.0)),
On 2016/02/12 19:31:42, scheglov wrote:
> On 2016/02/12 18:52:50, Paul Berry wrote:
> > Let's set these to the appropriate values rather than 0.0.  That is:
> double.NAN,
> > double.NEGATIVE_INFINITY, double.MIN_POSITIVE, and double.MAX_FINITE,
> > respectively.
> 
> Done.
> I had to specialize validation of NaN, which cannot be compared to each other.

Oh, yeah.  Stupid NaN!

Thanks :)

Powered by Google App Engine
This is Rietveld 408576698