Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Unified Diff: pkg/analyzer/lib/src/generated/testing/element_factory.dart

Issue 1688233004: Validate that (actual) resynthesized elements have the same runtimeType as originals. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Use actual double.X values. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/testing/test_type_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/testing/element_factory.dart
diff --git a/pkg/analyzer/lib/src/generated/testing/element_factory.dart b/pkg/analyzer/lib/src/generated/testing/element_factory.dart
index 72d8acff08648a7ba3b61ef71ef25e88aa69fbe9..7ea7a3a4f173bf892a315a578244fa42aef33e76 100644
--- a/pkg/analyzer/lib/src/generated/testing/element_factory.dart
+++ b/pkg/analyzer/lib/src/generated/testing/element_factory.dart
@@ -202,7 +202,8 @@ class ElementFactory {
}
static FieldElementImpl fieldElement(
- String name, bool isStatic, bool isFinal, bool isConst, DartType type) {
+ String name, bool isStatic, bool isFinal, bool isConst, DartType type,
+ {Expression initializer}) {
FieldElementImpl field = isConst
? new ConstFieldElementImpl(name, 0)
: new FieldElementImpl(name, 0);
@@ -210,6 +211,9 @@ class ElementFactory {
field.final2 = isFinal;
field.static = isStatic;
field.type = type;
+ if (isConst) {
+ (field as ConstFieldElementImpl).constantInitializer = initializer;
+ }
PropertyAccessorElementImpl getter =
new PropertyAccessorElementImpl.forVariable(field);
getter.getter = true;
@@ -496,6 +500,16 @@ class ElementFactory {
return parameter;
}
+ static ParameterElementImpl namedParameter3(String name,
+ {DartType type, Expression initializer}) {
+ DefaultParameterElementImpl parameter =
+ new DefaultParameterElementImpl(name, 0);
+ parameter.parameterKind = ParameterKind.NAMED;
+ parameter.type = type;
+ parameter.constantInitializer = initializer;
+ return parameter;
+ }
+
static ParameterElementImpl positionalParameter(String name) {
ParameterElementImpl parameter = new ParameterElementImpl(name, 0);
parameter.parameterKind = ParameterKind.POSITIONAL;
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/testing/test_type_provider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698