Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart

Issue 1688233004: Validate that (actual) resynthesized elements have the same runtimeType as originals. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Use actual double.X values. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
diff --git a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
index b3aaea89016c0d2b52c64bc3f295a108e4045ee2..b76272cf932f456edcd49d13ef2ced3b63bbd104 100644
--- a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
+++ b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
@@ -170,7 +170,8 @@ class TestTypeProvider implements TypeProvider {
.constructorElement(boolElement, "fromEnvironment", true);
fromEnvironment.parameters = <ParameterElement>[
ElementFactory.requiredParameter2("name", stringType),
- ElementFactory.namedParameter2("defaultValue", _boolType)
+ ElementFactory.namedParameter3("defaultValue",
+ type: _boolType, initializer: AstFactory.booleanLiteral(false))
];
fromEnvironment.factory = true;
fromEnvironment.isCycleFree = true;
@@ -195,7 +196,9 @@ class TestTypeProvider implements TypeProvider {
FieldElementImpl expiresField = ElementFactory.fieldElement(
'expires', false, true, false, stringType);
deprecatedElement.fields = <FieldElement>[expiresField];
- deprecatedElement.accessors = <PropertyAccessorElement>[expiresField.getter];
+ deprecatedElement.accessors = <PropertyAccessorElement>[
+ expiresField.getter
+ ];
ConstructorElementImpl constructor = ElementFactory
.constructorElement(deprecatedElement, '', true, [stringType]);
(constructor.parameters[0] as ParameterElementImpl).name = 'expires';
@@ -492,7 +495,7 @@ class TestTypeProvider implements TypeProvider {
.constructorElement(stringElement, "fromEnvironment", true);
fromEnvironment.parameters = <ParameterElement>[
ElementFactory.requiredParameter2("name", stringType),
- ElementFactory.namedParameter2("defaultValue", _stringType)
+ ElementFactory.namedParameter3("defaultValue", type: _stringType)
];
fromEnvironment.factory = true;
fromEnvironment.isCycleFree = true;
@@ -610,7 +613,7 @@ class TestTypeProvider implements TypeProvider {
ElementFactory.constructorElement(intElement, "fromEnvironment", true);
fromEnvironment.parameters = <ParameterElement>[
ElementFactory.requiredParameter2("name", stringType),
- ElementFactory.namedParameter2("defaultValue", _intType)
+ ElementFactory.namedParameter3("defaultValue", type: _intType)
];
fromEnvironment.factory = true;
fromEnvironment.isCycleFree = true;
@@ -623,18 +626,23 @@ class TestTypeProvider implements TypeProvider {
ElementFactory.constructorElement(doubleElement, null, false)
..synthetic = true
];
- ConstFieldElementImpl varINFINITY =
- ElementFactory.fieldElement("INFINITY", true, false, true, _doubleType);
+ ConstFieldElementImpl varINFINITY = ElementFactory.fieldElement(
+ "INFINITY", true, false, true, _doubleType,
+ initializer: AstFactory.doubleLiteral(double.INFINITY));
varINFINITY.constantInitializer = AstFactory.binaryExpression(
AstFactory.integer(1), TokenType.SLASH, AstFactory.integer(0));
List<FieldElement> fields = <FieldElement>[
- ElementFactory.fieldElement("NAN", true, false, true, _doubleType),
+ ElementFactory.fieldElement("NAN", true, false, true, _doubleType,
+ initializer: AstFactory.doubleLiteral(double.NAN)),
varINFINITY,
ElementFactory.fieldElement(
- "NEGATIVE_INFINITY", true, false, true, _doubleType),
+ "NEGATIVE_INFINITY", true, false, true, _doubleType,
+ initializer: AstFactory.doubleLiteral(double.NEGATIVE_INFINITY)),
ElementFactory.fieldElement(
- "MIN_POSITIVE", true, false, true, _doubleType),
- ElementFactory.fieldElement("MAX_FINITE", true, false, true, _doubleType)
+ "MIN_POSITIVE", true, false, true, _doubleType,
+ initializer: AstFactory.doubleLiteral(double.MIN_POSITIVE)),
+ ElementFactory.fieldElement("MAX_FINITE", true, false, true, _doubleType,
+ initializer: AstFactory.doubleLiteral(double.MAX_FINITE))
];
doubleElement.fields = fields;
int fieldCount = fields.length;
« no previous file with comments | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | pkg/analyzer/lib/src/summary/summarize_ast.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698