Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1688163004: [runtime] Kill %Arguments and %ArgumentsLength. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@StringFromCharCode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Kill %Arguments and %ArgumentsLength. This removes support for the %Arguments and %ArgumentsLength runtime entries and their intrinsic counterparts. If you need variable arguments in any builtin, either use (strict) arguments object or rest parameters, which are both compositional across inlining (in TurboFan), and not that much slower compared to the %_Arguments hackery. R=jarin@chromium.org Committed: https://crrev.com/98aec4a71962a16b00d32c4edf6694e3cab08797 Cr-Commit-Position: refs/heads/master@{#33943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1097 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/code-stubs.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/arguments-opt.js View 1 chunk +0 lines, -132 lines 0 comments Download
M test/mjsunit/compiler/inline-arguments.js View 1 chunk +0 lines, -26 lines 0 comments Download
M test/mjsunit/regress/regress-seqstrsetchar-ex1.js View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-12 11:35:47 UTC) #1
Benedikt Meurer
Hey Jaro, Let's kill it with fire! Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-12 11:36:38 UTC) #2
Jarin
lgtm, awesome!
4 years, 10 months ago (2016-02-12 11:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688163004/1
4 years, 10 months ago (2016-02-12 11:40:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 12:24:50 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 12:25:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98aec4a71962a16b00d32c4edf6694e3cab08797
Cr-Commit-Position: refs/heads/master@{#33943}

Powered by Google App Engine
This is Rietveld 408576698