Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1681403006: [builtins] Rewrite String.fromCharCode w/o %_Arguments. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Rewrite String.fromCharCode w/o %_Arguments. This is the very last use of %_Arguments and %_ArgumentsLength, and also the main blocker for not inlining builtins. R=yangguo@chromium.org Committed: https://crrev.com/fd940f5c6b45383197618a0bd58bbd5f675f4607 Cr-Commit-Position: refs/heads/master@{#33939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M src/js/string.js View 1 chunk +8 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-12 10:37:30 UTC) #1
Benedikt Meurer
Hey Yang, This was easier than expected initially. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-12 10:38:07 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-12 10:43:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681403006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681403006/1
4 years, 10 months ago (2016-02-12 10:46:55 UTC) #6
Yang
On 2016/02/12 10:46:55, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 10 months ago (2016-02-12 10:55:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 11:23:28 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 11:23:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd940f5c6b45383197618a0bd58bbd5f675f4607
Cr-Commit-Position: refs/heads/master@{#33939}

Powered by Google App Engine
This is Rietveld 408576698