Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/code-stubs.h

Issue 1688163004: [runtime] Kill %Arguments and %ArgumentsLength. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@StringFromCharCode
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 3da1cc56248408a33a2176fd0eb195148780d2c6..8d270d4fca6849f70373753676e69ea9ad6431ee 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1843,7 +1843,6 @@ class JSEntryStub : public PlatformCodeStub {
class ArgumentsAccessStub: public PlatformCodeStub {
public:
enum Type {
- READ_ELEMENT,
NEW_SLOPPY_FAST,
NEW_SLOPPY_SLOW,
};
@@ -1853,11 +1852,7 @@ class ArgumentsAccessStub: public PlatformCodeStub {
}
CallInterfaceDescriptor GetCallInterfaceDescriptor() const override {
- if (type() == READ_ELEMENT) {
- return ArgumentsAccessReadDescriptor(isolate());
- } else {
- return ArgumentsAccessNewDescriptor(isolate());
- }
+ return ArgumentsAccessNewDescriptor(isolate());
}
static Type ComputeType(bool has_duplicate_parameters) {
@@ -1871,13 +1866,12 @@ class ArgumentsAccessStub: public PlatformCodeStub {
private:
Type type() const { return TypeBits::decode(minor_key_); }
- void GenerateReadElement(MacroAssembler* masm);
void GenerateNewSloppyFast(MacroAssembler* masm);
void GenerateNewSloppySlow(MacroAssembler* masm);
void PrintName(std::ostream& os) const override; // NOLINT
- class TypeBits : public BitField<Type, 0, 2> {};
+ class TypeBits : public BitField<Type, 0, 1> {};
DEFINE_PLATFORM_CODE_STUB(ArgumentsAccess, PlatformCodeStub);
};
« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698