Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1688053003:
Avoid overwrite of existing PaintLayerReflectionInfo. (Closed)
|
Created:
4 years, 10 months ago by rune Modified:
4 years, 10 months ago CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid overwrite of existing PaintLayerReflectionInfo.
The check for an existing reflectionInfo on PaintLayer before
allocating a new one fell out of [1]. This fixes the crash in the
original report in crbug.com/585699.
[1] https://codereview.chromium.org/1636563003
R=chrishtr@chromium.org
BUG=585699
Committed: https://crrev.com/0cf436fa9f24983b9c3aa30ea3ddc4bae8dfa49e
Cr-Commit-Position: refs/heads/master@{#375169}
Patch Set 1 #Patch Set 2 : Fixed typo #Messages
Total messages: 19 (9 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
I've not been able to construct a test case for this yet.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688053003/1
Description was changed from ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original fuzzer case in crbug.com/585699, but not the minimized one (the call stack with svg in it). [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 ========== to ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original report in crbug.com/585699. [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688053003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + mstensho@opera.com
lgtm. Since this CL really is about just reverting some (hopefully) unintended changes from the PaintLayer rare data refactoring, and since the fuzzer test is flaky and hard to reduce into something meaningful, we can live without a test.
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1688053003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1688053003/20001
Message was sent while issue was closed.
Description was changed from ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original report in crbug.com/585699. [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 ========== to ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original report in crbug.com/585699. [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original report in crbug.com/585699. [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 ========== to ========== Avoid overwrite of existing PaintLayerReflectionInfo. The check for an existing reflectionInfo on PaintLayer before allocating a new one fell out of [1]. This fixes the crash in the original report in crbug.com/585699. [1] https://codereview.chromium.org/1636563003 R=chrishtr@chromium.org BUG=585699 Committed: https://crrev.com/0cf436fa9f24983b9c3aa30ea3ddc4bae8dfa49e Cr-Commit-Position: refs/heads/master@{#375169} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0cf436fa9f24983b9c3aa30ea3ddc4bae8dfa49e Cr-Commit-Position: refs/heads/master@{#375169} |
