third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 1688053003: Avoid overwrite of existing PaintLayerReflectionInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 1688053003: Avoid overwrite of existing PaintLayerReflectionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index 895daeef48f0d1fa51a5d3e6030c529f6ee116a5..15602b8ed1110683ec5b4201dc5b937ccfb063cc 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -1423,7 +1423,8 @@ void PaintLayer::updateReflectionInfo(const ComputedStyle* oldStyle)

{

ASSERT(!oldStyle || !layoutObject()->style()->reflectionDataEquivalent(oldStyle));

if (layoutObject()->hasReflection()) {

- ensureRareData().reflectionInfo = adoptPtr(new PaintLayerReflectionInfo(*layoutBox()));

+ if (!ensureRareData().reflectionInfo)

+ m_rareData->reflectionInfo = adoptPtr(new PaintLayerReflectionInfo(*layoutBox()));

m_rareData->reflectionInfo->updateAfterStyleChange(oldStyle);

} else if (m_rareData && m_rareData->reflectionInfo) {

m_rareData->reflectionInfo->destroy();

« no previous file with comments | « no previous file | no next file » | no next file with comments »