Issue 1687793003: Remove irrelevant TODOs from summary code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1687793003: Remove irrelevant TODOs from summary code. (Closed)

Created:
4 years, 10 months ago by Paul Berry

Modified:
4 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove irrelevant TODOs from summary code. Also remove the annotation `private` from idl.dart (it was never used). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9717305de4b5c999dc5e36ba6fe2f768e846531a

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -23 lines)			Patch
M	pkg/analyzer/lib/src/summary/idl.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/resynthesize.dart	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_ast.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	3 chunks	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 10 months ago (2016-02-10 16:34:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9717305de4b5c999dc5e36ba6fe2f768e846531a (presubmit successful).